Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): Add 5-appinfra instructions to deploy on foundation docs #49

Conversation

caetano-colin
Copy link
Contributor

@caetano-colin caetano-colin commented Jun 12, 2024

This PR completes the 'How to deploy on top of Foundation' documentation by adding the 5-appinfra steps to it.

README.md was adjusted to guide the user through the options available when deploying.

@caetano-colin caetano-colin changed the title (WIP) Add 5-appinfra instructions to deploy on foundation docs DRAFT: Add 5-appinfra instructions to deploy on foundation docs Jun 12, 2024
@caetano-colin caetano-colin changed the title DRAFT: Add 5-appinfra instructions to deploy on foundation docs DRAFT: feat(docs): Add 5-appinfra instructions to deploy on foundation docs Jun 13, 2024
@caetano-colin caetano-colin marked this pull request as ready for review June 14, 2024 11:36
@caetano-colin caetano-colin changed the title DRAFT: feat(docs): Add 5-appinfra instructions to deploy on foundation docs feat(docs): Add 5-appinfra instructions to deploy on foundation docs Jun 14, 2024
}

variable "project_id" {
description = "Project ID"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we have a type = string in this variable?

@sleighton2022 sleighton2022 merged commit e95edf3 into GoogleCloudPlatform:main Jun 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants